Skip to content

Conversation

vhoyer
Copy link
Collaborator

@vhoyer vhoyer commented Jan 18, 2023

No description provided.

@vhoyer vhoyer requested a review from carloscuesta January 18, 2023 00:58
@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
gitmoji ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 0:59AM (UTC)

@@ -9,7 +9,7 @@
],
"scripts": {
"prepare": "husky install",
"dev": "yarn turbo dev"
"dev": "yarn turbo --parallel dev"
Copy link
Owner

@carloscuesta carloscuesta Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! ❤️

TIL!

@@ -15,6 +15,7 @@
"dist"
],
"scripts": {
"dev": "nodemon --exec 'yarn build' --watch ./src",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached this point but was completely unaware of the parallel option!

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice!!

Thanks for the improvement @vhoyer ❤️

@carloscuesta carloscuesta merged commit 09525c5 into export-gitmojis-cjs-and-esm Jan 18, 2023
@carloscuesta carloscuesta deleted the export-gitmojis-cjs-and-esm-with-dev-watch branch January 18, 2023 18:29
carloscuesta added a commit that referenced this pull request Jan 18, 2023
* ➕ Install `unbuild` dependency
* 🚚 Rename `gitmojis.d.ts` to `index.d.ts`
* ✨ Export `cjs` and `esm` with `unbuild`
* 👷 Add `build` step to publish action
* 🔧 Add `gitmojis` build output to turborepo config
* 🔧 Add `build` as a dependency for `lint`, `tscheck` and `build`
* ✨ Add `assert { type: json }` for JSON imports
* 🧑‍💻 Watch changes on `gitmojis` to rebuild deps for website (#1282)

Co-authored-by: Vinícius Hoyer <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants