Skip to content

CIP-108 CIP-136 | Small schema fixes #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Jul 10, 2025

Changes

  • fix naming of @type property within CIP108 and CIP136 schemas

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure of changes look fine to me but I would look forward to other editors' technical review of context & possible consequences.

@rphair rphair added Update Adds content or significantly reworks an existing proposal State: Last Check Review favourable with disputes resolved; staged for merging. Category: Metadata Proposals belonging to the 'Metadata' category. labels Jul 10, 2025
@rphair rphair requested review from Crypto2099 and perturbing July 10, 2025 22:45
@gitmachtl
Copy link
Contributor

I welcome this change, looks good.

@Crypto2099
Copy link
Collaborator

Not sure that I understand the intent here? Having an empty array and thereby signalling no authors or anonymous authors was always a feature rather than a "bug" as far as I remember from the original workshops w/ @Quantumplation

@Quantumplation
Copy link
Contributor

Yes; I don't think it should be the purview of these specs to define what is required or not; it's to describe how to interpret the fields, if present.

It may make recommendations to tool authors about how to highlight deficiencies (ex: you might want to recommend that the lack of authors is highlighted clearly because of the anonymity, etc). But saying it's "required" implies the tool shouldn't show it at all if it's not present, or should mark it as invalid, which puts the thumb on the scale of governance.

@rphair
Copy link
Collaborator

rphair commented Jul 19, 2025

Will note #1056 (comment) & #1056 (comment) for Tuesday's agenda & trust @Crypto2099 and @Ryun1 will debate both sides of the issue and include @Quantumplation's interpretation of the proposed change.

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Jul 22, 2025

Thanks for the feedback @Crypto2099 @Quantumplation

you raise good points
and I agree

I have removed the requirement via 741ed74

@Ryun1 Ryun1 changed the title CIP-100 CIP-108 CIP-136 | Small schema fixes CIP-108 CIP-136 | Small schema fixes Jul 22, 2025
@Ryun1 Ryun1 merged commit 0bba264 into cardano-foundation:master Jul 22, 2025
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Metadata Proposals belonging to the 'Metadata' category. Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants