-
Notifications
You must be signed in to change notification settings - Fork 357
CIP-108 CIP-136 | Small schema fixes #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-108 CIP-136 | Small schema fixes #1056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure of changes look fine to me but I would look forward to other editors' technical review of context & possible consequences.
I welcome this change, looks good. |
Not sure that I understand the intent here? Having an empty array and thereby signalling no authors or anonymous authors was always a feature rather than a "bug" as far as I remember from the original workshops w/ @Quantumplation |
Yes; I don't think it should be the purview of these specs to define what is required or not; it's to describe how to interpret the fields, if present. It may make recommendations to tool authors about how to highlight deficiencies (ex: you might want to recommend that the lack of authors is highlighted clearly because of the anonymity, etc). But saying it's "required" implies the tool shouldn't show it at all if it's not present, or should mark it as invalid, which puts the thumb on the scale of governance. |
Will note #1056 (comment) & #1056 (comment) for Tuesday's agenda & trust @Crypto2099 and @Ryun1 will debate both sides of the issue and include @Quantumplation's interpretation of the proposed change. |
Thanks for the feedback @Crypto2099 @Quantumplation you raise good points I have removed the requirement via 741ed74 |
Changes
@type
property within CIP108 and CIP136 schemas