Customize ClangDeclId instead of customizing ClangDecl hashing and equality
#5725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d equality This keeps the principal of hashing and equality of a type includes all its values. Done by extending `CanonicalValueStore` to support calling a `TranslateValueToKey()` function defined in the `Id`, which converts the value to the key used for hashing. This is a draft. TODO: * Create a `ClangDeclStore` (possibly in a separate PR), to make its API clearer to use. * Add and update documentation. * Add tests.
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the principal of hashing and equality of a type includes all its values.
Done by extending
CanonicalValueStoreto support calling aTranslateValueToKey()function defined in theId, which converts the value to the key used for hashing.This is a draft.
TODO:
ClangDeclStore(possibly in a separate PR), to make its API clearer to use.