-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: a11y fix in multiselect #21177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: a11y fix in multiselect #21177
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21177 +/- ##
==========================================
- Coverage 85.14% 85.10% -0.05%
==========================================
Files 530 530
Lines 40900 40902 +2
Branches 6346 6345 -1
==========================================
- Hits 34826 34808 -18
- Misses 5913 5933 +20
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
riddhybansal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Closes #20890
Add aria-checked to MultiSelect and FilterableMultiSelect components to announce checkbox state
screen readers weren't announcing checkbox state (checked/unchecked) when navigating MultiSelect options with arrow keys.
Changelog
New
Added
aria-checkedattributeTesting / Reviewing
1/Open MultiSelect dropdown
2. Navigate options with arrow keys
3. Verify screen reader announces "checked" or "not checked" state
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide