Skip to content

Conversation

@2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Dec 15, 2025

Closes #20890

Add aria-checked to MultiSelect and FilterableMultiSelect components to announce checkbox state
screen readers weren't announcing checkbox state (checked/unchecked) when navigating MultiSelect options with arrow keys.

Changelog

New

Added aria-checked attribute

Testing / Reviewing

1/Open MultiSelect dropdown
2. Navigate options with arrow keys
3. Verify screen reader announces "checked" or "not checked" state

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bc9615f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6944150d71c66100089a0568
😎 Deploy Preview https://deploy-preview-21177--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bc9615f
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6944150d89aef50008c98a12
😎 Deploy Preview https://deploy-preview-21177--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc9615f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6944150dfcddde00080a85ba
😎 Deploy Preview https://deploy-preview-21177--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.10%. Comparing base (ea2b873) to head (bc9615f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21177      +/-   ##
==========================================
- Coverage   85.14%   85.10%   -0.05%     
==========================================
  Files         530      530              
  Lines       40900    40902       +2     
  Branches     6346     6345       -1     
==========================================
- Hits        34826    34808      -18     
- Misses       5913     5933      +20     
  Partials      161      161              
Flag Coverage Δ
main-packages 85.73% <100.00%> (+<0.01%) ⬆️
web-components 84.74% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2nikhiltom 2nikhiltom marked this pull request as ready for review December 18, 2025 13:56
@2nikhiltom 2nikhiltom requested a review from a team as a code owner December 18, 2025 13:56
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: MultiSelect - "Role and State of the control is not announced by the screen reader."

3 participants