-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(textarea): add controls args to every story #21170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(textarea): add controls args to every story #21170
Conversation
Signed-off-by: baadhira <[email protected]>
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: baadhira <[email protected]>
|
Hi @baadhira, just a heads up this issue covers the stories in both the React storybook and the Web Components storybook so controls will need to be added to both. |
…into feat/20956-textarea-controls
Signed-off-by: baadhira <[email protected]>
|
hi @maradwan26 Web Components Storybook (packages/web-components/src/components/textarea/textarea.stories.ts): |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21170 +/- ##
==========================================
- Coverage 85.15% 85.14% -0.01%
==========================================
Files 532 532
Lines 40989 40989
Branches 6297 6296 -1
==========================================
- Hits 34905 34902 -3
- Misses 5924 5927 +3
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to me! Just a couple minor tweaks/adjustments and cleanup
packages/web-components/src/components/textarea/textarea.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/textarea/textarea.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/textarea/textarea.stories.ts
Outdated
Show resolved
Hide resolved
…into feat/20956-textarea-controls
|
Hi @maradwan26 , thank you for the detailed feedback! I've addressed all the requested changes: |
maradwan26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! LGTM
Closes #20956
Adds Storybook controls (args/argTypes) to all stories in TextArea.stories.js to enable prop manipulation via the Controls panel.
Changelog
New
{{new thing}}Changed
argTypesand asharedArgsobject for the TextArea component.labelText,helperText,invalid,disabled,rows, etc.) as Storybook controls for every story, including the_WithLayerandwithAILabelexamples.Skeletonstory to passargsand included specificargTypesto hide irrelevant controls.Removed
{{removed thing}}Testing / Reviewing
TextAreacomponent in Storybook.labelText,helperText,invalid, anddisabledare visible and functional for the selected story. Changing a control value should immediately update the displayed component.labelText) are available.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this change(No new logic, so usually not required)Addressed any impact on accessibility (a11y)(No visual/structural changes)Tested for cross-browser consistency(Storybook changes generally don't require this)More details can be found in the pull request guide