Skip to content

Fix grabMatchesFromEmail() by decoding source #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix grabMatchesFromEmail() by decoding source #90

merged 1 commit into from
Jun 8, 2022

Conversation

michaelarnauts
Copy link
Contributor

Using grabMatchesFromEmail works with the encoded email source instead of the plain text one. This prevents some regexes from matching correctly.

PR #84 fixed this for seeInEmail and dontSeeInEmail, but forgot grabMatchesFromEmail.

Fixes #83

@Jamesking56
Copy link
Collaborator

Thanks for this 👍

@Jamesking56 Jamesking56 merged commit cb9e5ca into captbaritone:master Jun 8, 2022
@Jamesking56
Copy link
Collaborator

@michaelarnauts Released as v2.4.1 which should end up on Packagist shortly 👍

@michaelarnauts
Copy link
Contributor Author

@michaelarnauts Released as v2.4.1 which should end up on Packagist shortly 👍

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emails with returns that split text fail seeInEmail assertions
2 participants
@michaelarnauts @Jamesking56