Skip to content

Relax subject parameter in Email, as it can be null in mailcatcher #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Relax subject parameter in Email, as it can be null in mailcatcher #108

merged 1 commit into from
Jun 30, 2023

Conversation

shaynekasai
Copy link
Contributor

Mailcatcher can return null in subject. Now that PHP8 is strict, passing null will cause an type error.

@Jamesking56 Jamesking56 merged commit 295104e into captbaritone:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andychute andychute andychute approved these changes

@ike-mowgli-mor ike-mowgli-mor ike-mowgli-mor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaynekasai @andychute @ike-mowgli-mor @Jamesking56