Matthieu Franck test technique #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seblepers
reviewed
Mar 7, 2024
| Legendary : {data.pokemon?.specy?.is_legendary ? 'Yes' : 'No'} | ||
| <img src={data.pokemon?.sprites[0].sprites.front_default} alt={data.pokemon?.name} /> | ||
| </div> | ||
| <body className="px-4 md:px-28 lg:px-48 py-6"> |
There was a problem hiding this comment.
Ce composant est un peu long, il aurait pu être découpé.
| @@ -0,0 +1,20 @@ | |||
| export const convertDecimeterToCmAndMeter = (value: number | null | undefined): string => { | |||
There was a problem hiding this comment.
C'est un cas parfait pour des tests unitaires. Dommage de ne pas en avoir fait.
| const captureRate = data?.pokemon?.specy?.capture_rate | ||
|
|
||
| // Play the audio sound of the pokemon | ||
| const playCry = () => { |
|
Très bon test technique. |
|
Petite remarque cependant : la consigne était de créer une PR sur ton propre dépôt Github, pas sur celui de Cap Collectif. |
|
Hello Sébastien, Oui je n'avais pas bien compris sur le moment, je te renvoie le lien de ma PR sur mon dépôt. Lien : https://github.com/Matt-Fr/technical-test-pokedex/pull/1À bientôt, Matthieuenvoyé : 7 mars 2024 à 11:31de : Sebastien Lepers ***@***.***>à : cap-collectif/technical-test-pokedex ***@***.***>cc : Matt-Fr ***@***.***>, Author ***@***.***>objet : Re: [cap-collectif/technical-test-pokedex] Matthieu Franck test technique (PR #3) Petite remarque cependant : la consigne était de créer une PR sur ton propre dépôt Github, pas sur celui de Cap Collectif. Mais elle ne devait pas être très claire car tu n'es pas le seul à t'être trompé.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test technique de Matthieu Franck pour Cap Collectif