-
Notifications
You must be signed in to change notification settings - Fork 247
chore: refresh /security/fips #15667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15667 +/- ##
==========================================
+ Coverage 48.20% 49.70% +1.50%
==========================================
Files 37 37
Lines 5595 5804 +209
==========================================
+ Hits 2697 2885 +188
- Misses 2898 2919 +21
🚀 New features to boost your workflow:
|
Thank you @edisile for this page! Comments:Hero:
The benefits of FIPS for Ubuntu
FIPS compliance everywhere
![]() (btw @eliman11, I actually like the smaller ones here vs. the Figma lol, but PMs usually aren't so happy when they're so small, so dyt we should maintain what we've got now, or use assets from Figma? Ik it's a visual q, but thought I could use with some input from UX too :p
Resources
Thanks! |
Thanks @edisile, and thanks for trying to align the title heights in the resources section 😅 Just a couple of minor changes from me -
@mattea-turic idk why I prefer the bigger logos :') But it's a visual decision so will leave it up to you, I don't have a strong preference either way. I would vote to keep them on mobile though to limit the customization needed |
@mattea-turic @eliman11 thank you for the quick review! I addressed your comments, please let me know if there's any other issue |
One super minor change - could you capitalize "Software" like the stakeholder did on the copydoc? I'll +1 anyway though |
Done
Refresh /security/fips
QA
to QA locally
./run serve
ordotrun
Issue / Card
Fixes WD-27255
Help
QA steps - Commit guidelines