Skip to content

Conversation

Onibenjo
Copy link
Contributor

@Onibenjo Onibenjo commented Sep 24, 2025

Done

  • Fixes the modal form view on the /supermicro/contact-us page, which should be static (usually a fallback for JS disabled)

QA

Issue / Card

Fixes #
https://warthogs.atlassian.net/browse/WD-27348

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 11:49
@webteam-app
Copy link

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Supermicro forms from the old modal form implementation to use a new form generator system. The main fix addresses the modal form view issue on the /supermicro/contact-us page, which should be static rather than modal.

  • Replaces hardcoded form HTML with form generator calls using load_form() function
  • Creates separate form configurations for modal (/supermicro) and static (/supermicro-contact-us) versions
  • Removes the legacy shared form template that was previously used

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/supermicro/index.html Replaces hardcoded form container with form generator call
templates/supermicro/form-data.json Adds modal form configuration for main supermicro page
templates/supermicro/contact-us/index.html Replaces include statement with form generator call
templates/supermicro/contact-us/form-data.json Adds static form configuration for contact-us page
templates/shared/forms/interactive/supermicro.html Removes legacy form template (no longer needed)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.98%. Comparing base (9fae719) to head (451891b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15659   +/-   ##
=======================================
  Coverage   47.98%   47.98%           
=======================================
  Files          37       37           
  Lines        5570     5570           
=======================================
  Hits         2673     2673           
  Misses       2897     2897           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants