Skip to content

Conversation

k-dimple
Copy link
Contributor

No description provided.

@k-dimple k-dimple requested a review from SecondSkoll October 10, 2024 08:59
@SecondSkoll
Copy link
Collaborator

I think this should run on PR, as Vale doesn't currently run alongside our other checks.
I believe it should also be in sp-files/.github/workflows.
@evilnick to check my thoughts though :)

@evilnick
Copy link
Contributor

Thanks. Yes, it should go in the sp-files/.github/workflows so it gets copied when a new project is made
I think it's fine to run on a schedule to satisfy the metric requirement, even if we aren't actively recording it. Adding vale checks to the doc PR checks is probably a separate card

@k-dimple
Copy link
Contributor Author

@SecondSkoll and @evilnick thanks for the reviews, I have moved it under the sp-files folder.

@evilnick evilnick merged commit 0fadd8f into canonical:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants