Skip to content

Conversation

@steinbro
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run make test?

Moved here from canonical/craft-parts#1216 per suggestion of @mr-cal

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steinbro! Approving with some suggestions for improvement.

@steinbro
Copy link
Member Author

@medubelko thanks for the feedback. I've replaced the entity names with more realistic ones; hopefully @mr-cal doesn't find them too contrived.

@jahn-junior jahn-junior removed their request for review August 27, 2025 22:34
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal mr-cal merged commit cba259a into main Aug 28, 2025
15 of 17 checks passed
@mr-cal mr-cal deleted the work/project-vars-docs branch August 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants