fix: repeat track and arch for closed stdin #5720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
jahn-junior
reviewed
Aug 21, 2025
sergiusens
commented
Aug 22, 2025
Co-authored-by: JJ Coldiron <[email protected]> Signed-off-by: Sergio Schvezov <[email protected]>
Contributor
Author
|
@jahn-junior applied your suggestions |
Signed-off-by: JJ Coldiron <[email protected]>
jahn-junior
approved these changes
Aug 22, 2025
Contributor
jahn-junior
left a comment
jahn-junior
left a comment
There was a problem hiding this comment.
Thanks! I removed some whitespace so the second example renders correctly 👍
bepri
approved these changes
Aug 22, 2025
mr-cal
reviewed
Aug 22, 2025
sergiusens
commented
Aug 25, 2025
Signed-off-by: Sergio Schvezov <[email protected]>
EdmilsonRodrigues
pushed a commit
to EdmilsonRodrigues/snapcraft
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Sergio Schvezov <[email protected]> Signed-off-by: JJ Coldiron <[email protected]> Co-authored-by: JJ Coldiron <[email protected]>
wgreenberg
pushed a commit
to certbot/certbot
that referenced
this pull request
Dec 4, 2025
in canonical/snapcraft#5720, snapcraft made a change. `snapcraft status certbot` output changed from something like this: ``` Track Arch Channel Version Revision Progress latest amd64 stable 5.1.0 5057 - candidate ↑ ↑ - beta 5.2.1 5214 - edge 5.2.0.dev0 5210 - arm64 stable 5.1.0 5058 - candidate ↑ ↑ - beta 5.2.1 5215 - edge 5.2.0.dev0 5211 - armhf stable 5.1.0 5056 - candidate ↑ ↑ - beta 5.2.1 5213 - edge 5.2.0.dev0 5212 - ``` to this: ``` Track Arch Channel Version Revision Progress latest amd64 stable 5.1.0 5057 - latest amd64 candidate ↑ ↑ - latest amd64 beta 5.2.1 5214 - latest amd64 edge 5.2.0.dev0 5210 - latest arm64 stable 5.1.0 5058 - latest arm64 candidate ↑ ↑ - latest arm64 beta 5.2.1 5215 - latest arm64 edge 5.2.0.dev0 5211 - latest armhf stable 5.1.0 5056 - latest armhf candidate ↑ ↑ - latest armhf beta 5.2.1 5213 - latest armhf edge 5.2.0.dev0 5212 - ``` when its output is captured like it is in finish_release.py in the lines above the code i'm modifying here not matching on the beginning of lines makes this pattern a little less strict, but based on the rest of the pattern and the output here, i personally think this is fine after carefully verifying this works with the current state of things, i went ahead and finished the release with this change and it worked just fine. instead, this PR proposes a way to fix things going forward
bmw
added a commit
to certbot/certbot
that referenced
this pull request
Dec 8, 2025
in canonical/snapcraft#5720, snapcraft made a change. `snapcraft status certbot` output changed from something like this: ``` Track Arch Channel Version Revision Progress latest amd64 stable 5.1.0 5057 - candidate ↑ ↑ - beta 5.2.1 5214 - edge 5.2.0.dev0 5210 - arm64 stable 5.1.0 5058 - candidate ↑ ↑ - beta 5.2.1 5215 - edge 5.2.0.dev0 5211 - armhf stable 5.1.0 5056 - candidate ↑ ↑ - beta 5.2.1 5213 - edge 5.2.0.dev0 5212 - ``` to this: ``` Track Arch Channel Version Revision Progress latest amd64 stable 5.1.0 5057 - latest amd64 candidate ↑ ↑ - latest amd64 beta 5.2.1 5214 - latest amd64 edge 5.2.0.dev0 5210 - latest arm64 stable 5.1.0 5058 - latest arm64 candidate ↑ ↑ - latest arm64 beta 5.2.1 5215 - latest arm64 edge 5.2.0.dev0 5211 - latest armhf stable 5.1.0 5056 - latest armhf candidate ↑ ↑ - latest armhf beta 5.2.1 5213 - latest armhf edge 5.2.0.dev0 5212 - ``` when its output is captured like it is in finish_release.py in the lines above the code i'm modifying here not matching on the beginning of lines makes this pattern a little less strict, but based on the rest of the pattern and the output here, i personally think this is fine after carefully verifying this works with the current state of things, i went ahead and finished the release with this change and it worked just fine. instead, this PR proposes a way to fix things going forward (cherry picked from commit 9e7a98f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to have lost this feature during a version transition with one of those larger
migrations (seems like it was the one from click to craft-cli).
I also found a bug in how we used tabular where numbers were being autodetected.
make lint?make test?