Skip to content

docs: migrate the catkin plugin reference #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jahn-junior merged 3 commits into from
Aug 22, 2025
Merged

docs: migrate the catkin plugin reference #5718

jahn-junior merged 3 commits into from
Aug 22, 2025

Conversation

@jahn-junior
Copy link
Contributor

@jahn-junior jahn-junior commented Aug 20, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run make test?

@jahn-junior jahn-junior requested a review from mr-cal August 20, 2025 22:47
jahn-junior
jahn-junior commented Aug 20, 2025
View reviewed changes
Copy link
Contributor Author

@jahn-junior jahn-junior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-cal The snapcraft.io doc was pretty sparse, so I brought it up to speed with the rest of the plugin docs. I was hoping you could do a quick pass on the "Dependencies" and "How it works" sections (or pass it off to an ROS expert) before I open up the draft. Thanks in advance!

mr-cal
mr-cal reviewed Aug 21, 2025
View reviewed changes
Guillaumebeuzeboc
Guillaumebeuzeboc reviewed Aug 21, 2025
View reviewed changes
artivis
artivis reviewed Aug 21, 2025
View reviewed changes
mr-cal
mr-cal approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jahn-junior jahn-junior marked this pull request as ready for review August 21, 2025 16:00
@jahn-junior jahn-junior requested a review from medubelko as a code owner August 21, 2025 16:00
medubelko
medubelko approved these changes Aug 21, 2025
View reviewed changes
@mr-cal
Copy link
Collaborator

mr-cal commented Aug 21, 2025

Do you want to target hotfix/8.11?

@jahn-junior jahn-junior changed the base branch from main to hotfix/8.11 August 21, 2025 21:14
@jahn-junior jahn-junior force-pushed the work/catkin-plugin/SNAPCRAFT-1125 branch from b1cb9f6 to 37a57ba Compare August 21, 2025 21:21
@jahn-junior jahn-junior force-pushed the work/catkin-plugin/SNAPCRAFT-1125 branch from 37a57ba to c094fd6 Compare August 21, 2025 22:13
@jahn-junior
Copy link
Contributor Author

jahn-junior commented Aug 21, 2025 •
edited
Loading

Should be ready for merge now. Sorry for the messy history — I apparently forgot how to rebase today.

artivis
artivis reviewed Aug 22, 2025
View reviewed changes
@jahn-junior jahn-junior merged commit 6c9caf1 into hotfix/8.11 Aug 22, 2025
15 of 16 checks passed
@jahn-junior jahn-junior deleted the work/catkin-plugin/SNAPCRAFT-1125 branch August 22, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medubelko medubelko medubelko approved these changes

@mr-cal mr-cal mr-cal approved these changes

@Guillaumebeuzeboc Guillaumebeuzeboc Awaiting requested review from Guillaumebeuzeboc

+1 more reviewer

@artivis artivis artivis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jahn-junior @mr-cal @artivis @Guillaumebeuzeboc @medubelko