test: update new scenario test to fix linting error #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyandrewmeyer
approved these changes
Dec 17, 2025
dwilding
approved these changes
Dec 18, 2025
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
https://docs.astral.sh/ruff/rules/useless-expression/#known-problems suggests doing:
with pytest.warns(DeprecationWarning):
_ = ctx.charm_specif I understand correctly. What do you think?
testing/tests/test_context.py
Outdated
| ctx = Context(CharmBase, meta={'name': 'some-name'}) | ||
| with pytest.warns(DeprecationWarning): | ||
| ctx.charm_spec # type: ignore | ||
| ctx.charm_spec # type: ignore # noqa: B018 |
Contributor
Author
There was a problem hiding this comment.
Good call @dwilding
Suggested change
| ctx.charm_spec # type: ignore # noqa: B018 | |
| _ = ctx.charm_spec # type: ignore |
james-garner-canonical
changed the title
james-garner-canonical
merged commit 7a656f8
into
canonical:main
56 of 57 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
noqadirective to the test newly added in #2219, which is needed due to the linting updates in #2228.