backends/daemon: Allow for backend to determine its data/cache dirs #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The meat of this will be implemented in the Windows and Mac platforms. |
townsend2010
force-pushed
the
implement-backend-separation
branch
from
a477e60 to
23adb9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
=========================================
+ Coverage 68.69% 68.7% +<.01%
=========================================
Files 177 177
Lines 6273 6275 +2
=========================================
+ Hits 4309 4311 +2
Misses 1964 1964
Continue to review full report at Codecov.
|
|
Doesn't this complicate things a bit too much? Couldn't the platform+backend just return a string for the daemon to do with as it pleases? |
|
I thought about the approach you suggest, and I thought that approach is at least as complicated as this approach. However, thinking about it some more, it might be better to implement this in each backend's factory. I'll look into that. |
townsend2010
force-pushed
the
implement-backend-separation
branch
from
23adb9a to
e673fa3
Compare
townsend2010
changed the title
|
I updated this to have the backend's factory be the keeper of the data/cache directories. |
townsend2010
force-pushed
the
implement-backend-separation
branch
from
e673fa3 to
013434f
Compare
townsend2010
changed the title
townsend2010
changed the title
|
Ok, updated again:) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 24, 2019
800: backends/daemon: Allow for backend to determine its data/cache dirs r=Saviq a=townsend2010 Fixes #774 Co-authored-by: Chris Townsend <[email protected]>
Build failed |
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
800: backends/daemon: Allow for backend to determine its data/cache dirs r=Saviq a=townsend2010 Fixes #774 Co-authored-by: Chris Townsend <[email protected]>
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
800: backends/daemon: Allow for backend to determine its data/cache dirs r=Saviq a=townsend2010 Fixes #774 Co-authored-by: Chris Townsend <[email protected]>
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
800: backends/daemon: Allow for backend to determine its data/cache dirs r=Saviq a=townsend2010 Fixes #774 Co-authored-by: Chris Townsend <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #774