Fulfil promise for restart error condition #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=========================================
+ Coverage 68.28% 68.69% +0.4%
=========================================
Files 177 177
Lines 6272 6273 +1
=========================================
+ Hits 4283 4309 +26
+ Misses 1989 1964 -25
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=========================================
+ Coverage 68.28% 68.69% +0.4%
=========================================
Files 177 177
Lines 6272 6273 +1
=========================================
+ Hits 4283 4309 +26
+ Misses 1989 1964 -25
Continue to review full report at Codecov.
|
townsend2010
approved these changes
May 21, 2019
bors bot
added a commit
that referenced
this pull request
May 21, 2019
796: Fulfil promise for restart error condition r=townsend2010 a=gerboland Fixes #764. We were omitting to set a promised future, which caused the client to hang. I've added a basic test to catch this behaviour for this command. Later PR will try to generalise it for the other commands. Co-authored-by: Gerry Boland <[email protected]>
Build succeeded |
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
796: Fulfil promise for restart error condition r=townsend2010 a=gerboland Fixes #764. We were omitting to set a promised future, which caused the client to hang. I've added a basic test to catch this behaviour for this command. Later PR will try to generalise it for the other commands. Co-authored-by: Gerry Boland <[email protected]>
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
796: Fulfil promise for restart error condition r=townsend2010 a=gerboland Fixes #764. We were omitting to set a promised future, which caused the client to hang. I've added a basic test to catch this behaviour for this command. Later PR will try to generalise it for the other commands. Co-authored-by: Gerry Boland <[email protected]>
Saviq
pushed a commit
that referenced
this pull request
May 28, 2019
796: Fulfil promise for restart error condition r=townsend2010 a=gerboland Fixes #764. We were omitting to set a promised future, which caused the client to hang. I've added a basic test to catch this behaviour for this command. Later PR will try to generalise it for the other commands. Co-authored-by: Gerry Boland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764. We were omitting to set a promised future, which caused the client to hang.
I've added a basic test to catch this behaviour for this command. Later PR will try to generalise it for the other commands.