Skip to content

Fix the bug where VirtualMachine::shutdown function throw affects multipass delete #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 18, 2024

[qemu] localized force_shutdown true value setting so it can pair up …

7d01280
Select commit
Loading
Failed to load commit list.
Merged

Fix the bug where VirtualMachine::shutdown function throw affects multipass delete #3625

[qemu] localized force_shutdown true value setting so it can pair up …
7d01280
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 18, 2024 in 1s

62.79% of diff hit (target 88.85%)

View this Pull Request on Codecov

62.79% of diff hit (target 88.85%)

Annotations

Check warning on line 2150 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2150 

Added line #L2150 was not covered by tests

Check warning on line 2152 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2152 

Added line #L2152 was not covered by tests

Check warning on line 2156 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2156 

Added line #L2156 was not covered by tests

Check warning on line 2303 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2303 

Added line #L2303 was not covered by tests

Check warning on line 2305 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2305 

Added line #L2305 was not covered by tests

Check warning on line 2309 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L2309 

Added line #L2309 was not covered by tests

Check warning on line 3133 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3133 

Added line #L3133 was not covered by tests

Check warning on line 3137 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3135-L3137 

Added lines #L3135 - L3137 were not covered by tests

Check warning on line 3139 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3139 

Added line #L3139 was not covered by tests

Check warning on line 3141 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3141 

Added line #L3141 was not covered by tests

Check warning on line 3143 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3143 

Added line #L3143 was not covered by tests

Check warning on line 3151 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3151 

Added line #L3151 was not covered by tests

Check warning on line 3153 in src/daemon/daemon.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daemon/daemon.cpp#L3153 

Added line #L3153 was not covered by tests

Check warning on line 208 in src/platform/backends/shared/base_virtual_machine.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/platform/backends/shared/base_virtual_machine.cpp#L208 

Added line #L208 was not covered by tests
View more details on Codecov