[snapshots] Fix restore rollback #3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop applying the last snapshot when rolling back a failed snapshot restore. Instead, apply the intended snapshot only after every other restore step has succeeded, thereby dispensing with rolling back the apply step itself (as long as it is itself transactional). Fixes #3362.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
- Coverage 84.06% 84.06% -0.01%
==========================================
Files 251 251
Lines 13793 13792 -1
==========================================
- Hits 11595 11594 -1
Misses 2198 2198 ☔ View full report in Codecov by Sentry. |
townsend2010
pushed a commit
that referenced
this pull request
Jan 31, 2024
[snapshots] Fix restore rollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop applying the last snapshot when rolling back a failed snapshot
restore. Instead, apply the intended snapshot only after every other
restore step has succeeded, thereby dispensing with rolling back the
apply step itself (as long as it is itself transactional). Fixes #3362.