Allow using process substitution for cloud-init file #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-toterman
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
- Coverage 86.64% 86.54% -0.11%
==========================================
Files 218 218
Lines 10981 10904 -77
==========================================
- Hits 9515 9437 -78
- Misses 1466 1467 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
townsend2010
approved these changes
Aug 12, 2022
bors bot
added a commit
that referenced
this pull request
Aug 12, 2022
2700: Allow using process substitution for cloud-init file r=townsend2010 a=andrei-toterman Passing a process substitution to `--cloud-init` didn't work since it was checking if it received a regular file, but a process substitution returns a named pipe. Unfortunately QT doesn't have a way to check if a path is a named pipe, but fortunately `std::filesystem` does. fix #1589 Co-authored-by: Andrei Toterman <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 12, 2022
2700: Allow using process substitution for cloud-init file r=townsend2010 a=andrei-toterman Passing a process substitution to `--cloud-init` didn't work since it was checking if it received a regular file, but a process substitution returns a named pipe. Unfortunately QT doesn't have a way to check if a path is a named pipe, but fortunately `std::filesystem` does. fix #1589 Co-authored-by: Andrei Toterman <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2022
2700: Allow using process substitution for cloud-init file r=townsend2010 a=andrei-toterman Passing a process substitution to `--cloud-init` didn't work since it was checking if it received a regular file, but a process substitution returns a named pipe. Unfortunately QT doesn't have a way to check if a path is a named pipe, but fortunately `std::filesystem` does. fix #1589 Co-authored-by: Andrei Toterman <[email protected]>
|
Build failed: |
|
Again... bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a process substitution to
--cloud-initdidn't work since it was checking if it received a regular file, but a process substitution returns a named pipe. Unfortunately QT doesn't have a way to check if a path is a named pipe, but fortunatelystd::filesystemdoes.fix #1589