Skip to content

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Oct 6, 2021

No description provided.

@Saviq Saviq added this to the v1.8.0 milestone Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #2274 (4ef8ddd) into main (7100099) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
+ Coverage   83.97%   84.05%   +0.07%     
==========================================
  Files         203      203              
  Lines       10124    10116       -8     
==========================================
+ Hits         8502     8503       +1     
+ Misses       1622     1613       -9     
Impacted Files Coverage Δ
include/multipass/exceptions/workflow_exceptions.h 100.00% <ø> (ø)
src/daemon/daemon.cpp 56.93% <100.00%> (+0.13%) ⬆️
...workflow_provider/default_vm_workflow_provider.cpp 100.00% <100.00%> (ø)
src/client/cli/cmd/launch.cpp 78.48% <0.00%> (-0.09%) ⬇️
src/daemon/custom_image_host.cpp 97.59% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7100099...4ef8ddd. Read the comment docs.

Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. That said, I think you should also push the change to the test yaml as well and as mentioned in #2275, the zip file should ultimately be created when building the tests.

I'll conditionally approve this and allow you to merge later after updating the test yaml.

bors delegate+

@bors
Copy link
Contributor

bors bot commented Oct 8, 2021

✌️ Saviq can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Saviq
Copy link
Collaborator Author

Saviq commented Oct 11, 2021

bors r=townsend2010

@bors
Copy link
Contributor

bors bot commented Oct 11, 2021

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Required status check \"macOS\" is in progress.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Saviq Saviq merged commit 0473ec7 into main Oct 11, 2021
@bors bors bot deleted the workflow-runs-on-support branch October 11, 2021 11:22
Saviq added a commit that referenced this pull request Oct 12, 2021
2274: [workflows] add support for `runs-on` key r=townsend2010 a=Saviq



Co-authored-by: Michał Sawicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants