[daemon] Fix regression in Workflows-based launches #2171
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2171 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 186 186
Lines 9632 9637 +5
=======================================
+ Hits 7957 7962 +5
Misses 1675 1675
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I am ok with this in general, but I would ask that the check be extracted into a validate_image auxiliary function (receiving the vault and the workflow_provider) and that that function be called from validate_create_arguments, which would need to receive the full config (or even be made a private method of the daemon).
That would allow dropping the comment explaining that the purpose of the code is validating the image (clear from the function name) and avoid adding to an already very long function, where individual calls are easily missed.
|
✌️ townsend2010 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r=ricab |
2171: [daemon] Fix regression in Workflows-based launches r=ricab a=townsend2010 Fixes #2170 Co-authored-by: Chris Townsend <[email protected]> Co-authored-by: Ricardo Abreu <[email protected]>
|
Build failed: |
|
Sigh... bors retry |
|
Build failed: |
2171: [daemon] Fix regression in Workflows-based launches r=ricab a=townsend2010 Fixes #2170 Co-authored-by: Chris Townsend <[email protected]> Co-authored-by: Ricardo Abreu <[email protected]>
Fixes #2170