[cli] Info For No Active Mounts #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[tests] no mounts.
[cli] adding empty mount info.
[cli] outputs "--" when no active mounts.
Codecov Report
@@ Coverage Diff @@
## main #2124 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 184 184
Lines 9455 9458 +3
=======================================
+ Hits 7740 7743 +3
Misses 1715 1715
Continue to review full report at Codecov.
|
[cli] removed extra braces.
surahman
changed the title
[cli] removed extra braces and white space.
|
bors try |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2021
2124: [cli] Info For No Active Mounts r=townsend2010 a=surahman **_Issue #2108:_** Should output `--` when no active mounts are available in conformity with `table` output for other unavailable information: https://github.com/surahman/multipass/blob/5f9ba4bd6db5fa31f59cbae0fbbf8fb3556e2d29/tests/test_output_formatter.cpp#L431-L452 The other formatters seem to already handle this situation. `YAML` outputs its `null` indicator as a tilde `~` character, `JSON` will create a `null` sub-record, and `CSV` will output an empty field. Co-authored-by: Saad Ur Rahman <[email protected]>
tryBuild succeeded: |
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2021
2124: [cli] Info For No Active Mounts r=townsend2010 a=surahman **_Issue #2108:_** Should output `--` when no active mounts are available in conformity with `table` output for other unavailable information: https://github.com/surahman/multipass/blob/5f9ba4bd6db5fa31f59cbae0fbbf8fb3556e2d29/tests/test_output_formatter.cpp#L431-L452 The other formatters seem to already handle this situation. `YAML` outputs its `null` indicator as a tilde `~` character, `JSON` will create a `null` sub-record, and `CSV` will output an empty field. Co-authored-by: Saad Ur Rahman <[email protected]>
|
Build failed: |
|
Try it again: bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2021
2124: [cli] Info For No Active Mounts r=townsend2010 a=surahman **_Issue #2108:_** Should output `--` when no active mounts are available in conformity with `table` output for other unavailable information: https://github.com/surahman/multipass/blob/5f9ba4bd6db5fa31f59cbae0fbbf8fb3556e2d29/tests/test_output_formatter.cpp#L431-L452 The other formatters seem to already handle this situation. `YAML` outputs its `null` indicator as a tilde `~` character, `JSON` will create a `null` sub-record, and `CSV` will output an empty field. Co-authored-by: Saad Ur Rahman <[email protected]>
|
Build failed: |
|
Ok, this is the last time, otherwise I'm just going to merge manually. bors retry |
|
Build failed: |
|
Ok, I'm bored with bors. Will merge this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2108:
Should output
--when no active mounts are available in conformity withtableoutput for other unavailable information:https://github.com/surahman/multipass/blob/5f9ba4bd6db5fa31f59cbae0fbbf8fb3556e2d29/tests/test_output_formatter.cpp#L431-L452
The other formatters seem to already handle this situation.
YAMLoutputs itsnullindicator as a tilde~character,JSONwill create anullsub-record, andCSVwill output an empty field.