[build] Use OpenSSL instead of gRPC's boringssl #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
19aa11c to
e1ab4f2
Compare
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
e1ab4f2 to
5e1512d
Compare
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
5e1512d to
ea3b0eb
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 227 227
Lines 8328 8328
=======================================
Hits 6349 6349
Misses 1979 1979
Continue to review full report at Codecov.
|
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
ea3b0eb to
3ccad79
Compare
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
3ccad79 to
a36cfea
Compare
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
a36cfea to
071648a
Compare
This comment has been minimized.
This comment has been minimized.
|
You can remove the |
Ah, right, cool! |
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
071648a to
413c68f
Compare
This comment has been minimized.
This comment has been minimized.
townsend2010
force-pushed
the
use-openssl-not-boringssl
branch
from
413c68f to
530756c
Compare
|
macOS build available: multipass-1.5.0-dev.173.pr1659+g995f13ae.mac-Darwin.pkg |
|
Noice! bors merge |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2020
1659: [build] Use OpenSSL instead of gRPC's boringssl r=Saviq a=townsend2010 Fixes #1368 Co-authored-by: Chris Townsend <[email protected]>
|
Build failed: |
|
Hum. Try again? bors merge |
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368