Skip to content

[snap] skip RelWithDebInfo if we don't have secure vars #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

[snap] skip RelWithDebInfo if we don't have secure vars #1454

merged 1 commit into from
Mar 30, 2020

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Mar 30, 2020 •
edited
Loading

The tests get run in Coverage, and RelWithDebInfo tries to publish after a successful build, for which we don't have credentials.

@ricab
Copy link
Collaborator

ricab commented Mar 30, 2020

Hey, just had a look at the code, but could you explain what is going on in there a bit? Thank you.

@Saviq Saviq changed the title [snap] skip publishing if we don't have secure vars [snap] skip RelWithDebInfo if we don't have secure vars Mar 30, 2020
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 30, 2020

@ricab I've modified this to be a simpler change - but to explain:

We tried to decrypt our credentials, which is only possible when the PR comes from the same repository. That's why #1420 failed - so this change disables that one job altogether. We run the tests in the Coverage job anyway, and bors will then run through the whole suite on try / merge.

ricab
ricab approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, lgtm

bors r+

bors bot added a commit that referenced this pull request Mar 30, 2020
@bors @Saviq
Merge #1454
6e84df5 
1454: [snap] skip RelWithDebInfo if we don't have secure vars r=ricab a=Saviq

The tests get run in Coverage, and RelWithDebInfo tries to publish after a successful build, for which we don't have credentials.

Co-authored-by: Michał Sawicz <[email protected]>
@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #1454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files         209      209           
  Lines        7572     7572           
=======================================
  Hits         5550     5550           
  Misses       2022     2022

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cab2e...2f659f3. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Mar 30, 2020

Build failed

@Saviq
Copy link
Collaborator Author

Saviq commented Mar 30, 2020

This is wrong… it should have ran RelWithDebInfo, too… digging.

@ricab
Copy link
Collaborator

ricab commented Mar 30, 2020

Indeed, weird. I guess the var is not being established.

@Saviq
Copy link
Collaborator Author

Saviq commented Mar 30, 2020

bors try

bors bot added a commit that referenced this pull request Mar 30, 2020
@bors
Try #1454:
e5f392a
@canonical canonical deleted a comment from bors bot Mar 30, 2020
@bors
Copy link
Contributor

bors bot commented Mar 30, 2020

try

Build failed

@Saviq
[travis] skip RelWithDebInfo, too if we're not secure
2f659f3 
The tests get run in Coverage, and RelWithDebInfo tries to publish after a successful build, for which we don't have credentials.
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 30, 2020

bors try

bors bot added a commit that referenced this pull request Mar 30, 2020
@bors
Try #1454:
b499678
ricab
ricab approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, better this way indeed

@ricab
Copy link
Collaborator

ricab commented Mar 30, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 30, 2020

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented Mar 30, 2020

Build succeeded

@bors bors bot merged commit 4a48834 into canonical:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @ricab