Top level catch all

[ricab]

Fixes #1429.

---

Manual test examples (beyond unit tests):

• Daemon :

$ ./bin/multipassd --logger=stderr -V debug  # non-admin user, no sudo

• CLI client:

$ chmod -r ~/.local/share/multipass/client-certificate/multipass_cert.pem  # don't forget to revert
$ multipass

• GUI client:

$ echo asdf > ~/.config/multipass/multipass.conf  # don't forget to revert
$ multipass.gui

[codecov]

Codecov Report

Merging #1430 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
+ Coverage   73.21%   73.24%   +0.02%     
==========================================
  Files         208      209       +1     
  Lines        7549     7557       +8     
==========================================
+ Hits         5527     5535       +8     
  Misses       2022     2022

Impacted Files	Coverage Δ
include/multipass/top_catch_all.h	100% <100%> (ø)
include/multipass/logging/cstring.h	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13243a...abd64e8. Read the comment docs.

[luis4a0]

The code is clear and seems to be in the correct place (in a new file). I tested it works well. The tests cover much cases, including the std::runtime_error, which is the most commonly raised exception.

I'll approve the PR, leaving the comments in the code as suggestions.

[luis4a0]

bors r+

[multipass-ci-bot]

macOS build available: multipass-1.2.0-dev.95.pr1430+g59799500.mac-Darwin.pkg
Snap build available: snap refresh multipass --channel edge/pr1430

[bors]

Build succeeded

• continuous-integration/travis-ci/push