Skip to content

xz_decoder: Update submodule #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

xz_decoder: Update submodule #1300

merged 1 commit into from
Jan 14, 2020

Conversation

townsend2010
Copy link
Contributor

No description provided.

@multipass-ci-bot
Copy link
Collaborator

multipass-ci-bot commented Jan 13, 2020 •
edited
Loading

macOS build available: multipass-1.1.0-dev.563+ga4aa293c.mac-Darwin.pkg
Snap build available: snap refresh multipass --channel edge/pr1300 or multipass_1.1.0-dev.42.pr1300+g94f933e_amd64.snap

ricab
ricab reviewed Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is caused by this, but I tried launching a core18 image and it gets stuck preparing the image. It doesn't even time out (which may be a separate problem). The only thing that is logged for this is AppArmor-policy loading and removal for qemu-img.

I tried it twice with the same result. When the daemon is killed and relaunched, it removes the image:

[2020-01-14T12:31:52.188] [info] [image vault] Source image /home/ricab/.cache/multipassd/vault/images/core-18-20190806 is no longer valid. Removing it from the cache.

@townsend2010
Copy link
Contributor Author

@ricab,

I've seen this behavior when running multipassd from source builds. Snap builds don't have the problem. I haven't taken the time to figure out what is happening, but it's not related to this submodule update.

@ricab
Copy link
Collaborator

ricab commented Jan 14, 2020

@townsend2010 OK, good to go then.

ricab
ricab approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bors r+

bors bot added a commit that referenced this pull request Jan 14, 2020
@bors
Merge #1300
31ad44c 
1300: xz_decoder: Update submodule r=ricab a=townsend2010



Co-authored-by: Chris Townsend <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2020

Build succeeded

@bors bors bot merged commit 4559811 into master Jan 14, 2020
@bors bors bot deleted the update-xz-decoder branch January 14, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@townsend2010 @multipass-ci-bot @ricab