[utils] resolve symlinks to snap directories (Fixes #1223) #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 71.32% 71.33% +<.01%
==========================================
Files 203 203
Lines 7478 7480 +2
==========================================
+ Hits 5334 5336 +2
Misses 2144 2144
Continue to review full report at Codecov.
|
Saviq
force-pushed
the
fix-symlinked-snap
branch
from
b818d62 to
b79a62f
Compare
Saviq
force-pushed
the
fix-symlinked-snap
branch
from
b79a62f to
fb06e79
Compare
This comment has been minimized.
This comment has been minimized.
Just hardcoding /var/lib/snapd since this goes away with strict anyway.
Saviq
force-pushed
the
fix-symlinked-snap
branch
from
fb06e79 to
bfa9cca
Compare
|
Snap build available: |
ricab
approved these changes
Dec 13, 2019
bors bot
added a commit
that referenced
this pull request
Dec 13, 2019
1228: [utils] resolve symlinks to snap directories (Fixes #1223) r=ricab a=Saviq Co-authored-by: Michał Sawicz <[email protected]>
Build failed |
Saviq
added a commit
that referenced
this pull request
Dec 13, 2019
1228: [utils] resolve symlinks to snap directories (Fixes #1223) r=ricab a=Saviq Co-authored-by: Michał Sawicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.