-
Notifications
You must be signed in to change notification settings - Fork 727
Closed
Labels
bughighHigh priority. Combine with "medium" to signal intermediate medium-high priority.High priority. Combine with "medium" to signal intermediate medium-high priority.jiraCreate a Jira ticket for this issueCreate a Jira ticket for this issuemediumMedium priority. Combine with "low" or "high" to signal intermediate priority.Medium priority. Combine with "low" or "high" to signal intermediate priority.
Description
Describe the bug
The mount target is not checked/validated to be a valid path. This allows for interesting targets to be used.
To Reproduce
- launch multipass GUI
- create a mount with a valid source but invalid target such as
" & mkdir hello & "
- observe mount fails for some reason, that may not be "bad mount point"
- shell into the instance
- observe
~/hello
exists
Also works in CLI but less interesting.
Expected behavior
The daemon prevents the usage of such targets without allowing side effects.
Additional context
Mount source is verified to be an existing file but, it might make sense to also validate the source as well. Windows paths are important to consider for both source and target since C:\foo\
is a valid path.
Metadata
Metadata
Assignees
Labels
bughighHigh priority. Combine with "medium" to signal intermediate medium-high priority.High priority. Combine with "medium" to signal intermediate medium-high priority.jiraCreate a Jira ticket for this issueCreate a Jira ticket for this issuemediumMedium priority. Combine with "low" or "high" to signal intermediate priority.Medium priority. Combine with "low" or "high" to signal intermediate priority.