Every time I ignore the multipass for windows update prompt, it queues an additional event handler. All of them fire at once when I actually click it

[parktheredcar]

Describe the bug
On windows, multipass update notifier is opening the github releases page many times when I click the update notification prompt - one tab for every time I didn't click it previously.

To Reproduce
How, and what happened?

1. Install multipass for windows
2. Wait for a new release and ignore the update prompt notification
3. Maybe ignore the notification when it pops up a few more times. Keep count of how many times you ignored it (N times)
4. Finally, click the update notification. It opens the same multipass github releases page in N duplicate tabs
5. Close all the extra tabs

Expected behavior
Clicking the update notification one time opens one single tab.

Logs
n/a
Additional info
Windows 10 20H2

Additional context
n/a

[Saviq]

Hi @parktheredcar, you should never ignore it, then! ;)

But for real, I believe the issue is that we indeed connect the action multiple times, we need to disconnect first:

multipass/src/client/gui/gui_cmd.cpp

Lines 252 to 253 in 2126b95

	QObject::connect(&tray_icon, &QSystemTrayIcon::messageClicked,
	[this] { QDesktopServices::openUrl(QUrl(update_action.whatsThis())); });

[surahman]

@Saviq I was poking around the documentation and found a method to check if a signal is connect:

        const auto connection_check = QMetaMethod::fromSignal(&QSystemTrayIcon::messageClicked);
        if (!isSignalConnected(connection_check))
        {
            QObject::connect(&tray_icon, &QSystemTrayIcon::messageClicked,
                             [this] { QDesktopServices::openUrl(QUrl(update_action.whatsThis())); });
        }

I am not sure if this will alleviate the issue. I have not been able to test this because I have not figured out how to downgrade the build numbers so as to trigger the message. The code is on a branch ready to PR once tested.

[Saviq]

@surahman thanks, that indeed looks like it will do the trick, can you put up a PR and we can take it from there?

[Saviq]

Fixed in #2193