Merged
Conversation
Contributor
jmucc
commented
Apr 6, 2026
jmucc
commented
- Refresh package profiles
- Refresh removal profiles
- Refresh upgrade profiles
- Clarify what data exchange means in removal profiles
YanisaHS
requested changes
Apr 6, 2026
docs/reference/terms/profiles.md
Outdated
Comment on lines
+42
to
+44
| ```{note} | ||
| Pings do not count as message exchanges, except for Windows hosts. | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ```{note} | |
| Pings do not count as message exchanges, except for Windows hosts. | |
| ``` | |
| Note that pings do not count as message exchanges, except for Windows hosts. |
Trying to have fewer note blocks throughout our docs. They're should be used for more side notes that you need to know, like what version of Landscape it applies to, etc.
Collaborator
There was a problem hiding this comment.
I know this wasn't in the original work - but you've included that you addressed what a "data exchange" is in removal profiles?
I don't think it's that clear in your PR actually. You should add another sentence there after "data for long periods of time." (one more sentence to Line 40). Something like "Landscape considers any message (including pings) sent from the client to be data exchanged. Note that pings " feel free to reword it though!
Co-authored-by: Yanisa Haley Scherber <yhscherber@gmail.com>
Co-authored-by: Yanisa Haley Scherber <yhscherber@gmail.com>
Co-authored-by: Yanisa Haley Scherber <yhscherber@gmail.com>
Co-authored-by: Yanisa Haley Scherber <yhscherber@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.