-
Notifications
You must be signed in to change notification settings - Fork 90
ci: add manual spread label, match other crafts #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Type checking with Command output |
|
Type checking with Command output |
|
Type checking with Command output |
|
Type checking with Command output |
|
Test failures are out of scope here. Thanks for the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces the spread-large.yaml workflow with a new spread-manual.yaml workflow that adds manual trigger functionality via the 'PR: Run Manual Spread' label. The new workflow introduces a predicate job to conditionally run tests based on whether they are triggered by a schedule, manual dispatch, or the presence of the label on a PR, making it more flexible and aligned with similar patterns in other Canonical craft projects.
Key changes:
- Introduces a predicate job that evaluates whether tests should run based on event type or PR labels
- Adds snap-build job to build the charmcraft snap from source instead of downloading from the edge channel
- Updates pull request triggers to include the "labeled" event type to support the new label-based workflow execution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/spread-manual.yaml | New workflow file that replaces spread-large.yaml with conditional execution via predicate job, snap building, and label-based triggering |
| .github/workflows/spread-large.yaml | Removed the old weekly spread workflow that unconditionally ran on schedule and workflow_dispatch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Type checking with Command output |
|
Type checking with Command output |
Adds the 'PR: Run Manual Spread' label functionality and makes it behave more closely to how the other crafts do their manual spread workflows.