[7.0][FIX] Make magentoerpconnect_discount_line compatible magento 2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoux
force-pushed
the
fix_with_magento_2
branch
from
76adcc2 to
66a6b47
Compare
sebalix
approved these changes
Mar 23, 2020
Member
sebalix
left a comment
sebalix
left a comment
There was a problem hiding this comment.
Pre-approving, small comment.
|
|
||
| @mapping | ||
| def price(self, record): | ||
| """ tax key may not be present in magento2 when no taxes apply """ |
Member
There was a problem hiding this comment.
Some details are welcomed regarding the issue related to discount :)
jcoux
force-pushed
the
fix_with_magento_2
branch
from
66a6b47 to
81905dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.