Skip to content

Conversation

@Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Dec 25, 2025

Description

  • Replace polling-based output waiting with condition variable for efficient CPU usage
  • Fix command escaping for Docker backend using shlex.quote
  • Properly activate virtual environment instead of replacing python/pip commands
  • Add bounded queue (10k items) with overflow handling to prevent memory exhaustion
  • Fix race condition in session creation with atomic check-and-create
  • Actually clone packages when cloning environment
  • Improve path comparison in sanitize_command using os.path.commonpath
  • Pre-compile regex patterns for better performance
  • Use print() instead of logger.info() for user-facing prompts in interactive mode
  • Remove unused default packages (pyautogui, plotly) from environment setup
  • Fix duplicate NotFound exception handling in Docker setup

related to issue: #3611

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch terminal_enhance1225

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 25, 2025
@Wendong-Fan Wendong-Fan marked this pull request as ready for review December 25, 2025 20:46
@Wendong-Fan Wendong-Fan self-assigned this Dec 25, 2025
@Wendong-Fan
Copy link
Member Author

Wendong-Fan commented Dec 25, 2025

hey @fengju0213 and @Michaelsqj @nitpicker55555 , I will merge this PR first for quick fixing, let me know if there's anything we need to update

@Wendong-Fan Wendong-Fan merged commit 11e521a into master Dec 25, 2025
14 of 15 checks passed
@Wendong-Fan Wendong-Fan deleted the terminal_enhance1225 branch December 25, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants