Skip to content

Conversation

@Wendong-Fan
Copy link
Member

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch outlook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 19, 2025
@Wendong-Fan Wendong-Fan marked this pull request as ready for review December 19, 2025 18:05
@Wendong-Fan Wendong-Fan merged commit 74c1c2f into master Dec 19, 2025
13 of 14 checks passed
@Wendong-Fan Wendong-Fan deleted the outlook branch December 19, 2025 18:05
@Tanuj-Taneja1
Copy link
Collaborator

Hi @Wendong-Fan
A major issue with this pr
The post(), get(), patch() in msgraph are async-only, making the functions synchronous cause errors errors like

/content/camel/camel/toolkits/microsoft_outlook_mail_toolkit.py:899: RuntimeWarning: coroutine 'SendMailRequestBuilder.post' was never awaited
  self.client.me.send_mail.post(request)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This basically causes all the tools to be unusable. I dont think these changes have been shiped to the new version yet so we should probably revert it back
(Sorry I was out on vacation so could not look at the pr sooner)

include_attachments=include_attachment_metadata,
attachment_metadata_only=True,
include_inline_attachments=True,
include_inline_attachments=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wendong-Fan
Shouldnt we include inline attachments to include screenshots and other attachments that might be releveant?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wendong-Fan Shouldnt we include inline attachments to include screenshots and other attachments that might be releveant?

Hi @Wendong-Fan , we have fixed the major issue in the pr just this minor issue remain, i think it is better to have meta data details of inline images as well like screenshot in list message tool. Would like your opinion on this.

@Tanuj-Taneja1
Copy link
Collaborator

Hi @fengju0213 can you also take a look at this pr since it reverts some of your changes (mainly async related).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants