Skip to content

Conversation

@waleedalzarooni
Copy link
Collaborator

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • [X ] I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • [ X] I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • [X ] I have updated the tests accordingly (required for a bug fix or a new feature)
  • [X ] I have updated the documentation if needed:
  • [ X] I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gmail-toolkit-naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 4, 2025
Copy link
Collaborator

@JINO-ROHIT JINO-ROHIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are just adding the prefixes is it? any idea why we need to do this? just asking for my understanding

Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a7m-1st
Copy link
Collaborator

a7m-1st commented Dec 4, 2025

@JINO-ROHIT it is because the agent doesn't know the toolkit belongs to gmail toolkit as it doesn't know about the file name.

@fengju0213
Copy link
Collaborator

these are just adding the prefixes is it? any idea why we need to do this? just asking for my understanding

For example, suppose we configure both Resend and Gmail, and they each have a function called send_email.
Now, when you tell the agent to use Gmail to send an email, the agent might not be able to choose the correct tool at runtime — because both toolkits define a function with the same name, send_email.

@fengju0213
Copy link
Collaborator

thanks for this pr!@waleedalzarooni

@fengju0213 fengju0213 enabled auto-merge (squash) December 5, 2025 05:10
Copy link
Collaborator

@JINO-ROHIT JINO-ROHIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks everyone! makes sense

@fengju0213 fengju0213 merged commit f8ba740 into master Dec 5, 2025
12 of 14 checks passed
@fengju0213 fengju0213 deleted the gmail-toolkit-naming branch December 5, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants