-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Wokforce support configurable fail handling #3488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wokforce support configurable fail handling #3488
Conversation
This reverts commit 516cfce.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hesamsheikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good to me. thanks @Wendong-Fan.
| }, | ||
| ] | ||
|
|
||
| # Generate available strategies text based on config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling _get_available_strategies_text() without checking if strategies are empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_analyze_task would only be used for case with multi-strategy, so i think it should be fine
LIHUA919
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The reassignment mechanism in Workforce was originally designed for scenarios where the initially assigned agent wasn't suitable for the task. However, as LLM capabilities have improved, the initial assignment is now almost always optimal. Consequently, if a task fails, reassigning it to a different agent rarely leads to success. Therefore, it is necessary to make this default reassignment setting configurable.
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!