Skip to content

Conversation

@Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Dec 2, 2025

Description

The reassignment mechanism in Workforce was originally designed for scenarios where the initially assigned agent wasn't suitable for the task. However, as LLM capabilities have improved, the initial assignment is now almost always optimal. Consequently, if a task fails, reassigning it to a different agent rarely leads to success. Therefore, it is necessary to make this default reassignment setting configurable.

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/workforce-configurable-fail-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 2, 2025
@Wendong-Fan Wendong-Fan self-assigned this Dec 2, 2025
@Wendong-Fan Wendong-Fan linked an issue Dec 2, 2025 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan added this to the Sprint 43 milestone Dec 2, 2025
@Wendong-Fan Wendong-Fan marked this pull request as ready for review December 2, 2025 13:47
Copy link
Collaborator

@hesamsheikh hesamsheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me. thanks @Wendong-Fan.

},
]

# Generate available strategies text based on config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling _get_available_strategies_text() without checking if strategies are empty.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_analyze_task would only be used for case with multi-strategy, so i think it should be fine

@fengju0213 fengju0213 added Waiting for Update PR has been reviewed, need to be updated based on review comment and removed Review Required PR need to be reviewed labels Dec 5, 2025
@Wendong-Fan Wendong-Fan removed the Waiting for Update PR has been reviewed, need to be updated based on review comment label Dec 14, 2025
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 43, Sprint 44 Dec 14, 2025
@Wendong-Fan Wendong-Fan merged commit 4da5487 into master Dec 14, 2025
14 checks passed
@Wendong-Fan Wendong-Fan deleted the feature/workforce-configurable-fail-handling branch December 14, 2025 08:46
Copy link
Collaborator

@LIHUA919 LIHUA919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Make fail handling mechanism in Workforce configurable

5 participants