-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[enhance] Workflow Saving Update Existing md Files #3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fengju0213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @hesamsheikh sorry for late reply!!
| target_workflow_filename: Optional[str] = Field( | ||
| description=( | ||
| "When operation_mode is 'update', specify the exact filename " | ||
| "(without .md extension) of the loaded workflow to update. " | ||
| "Must match one of the loaded workflow filenames exactly. " | ||
| "Leave empty or null when operation_mode is 'create'." | ||
| ), | ||
| default=None, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your opinion, do you think if given the file name we can always assume its update ? @hesamsheikh
a7m-1st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it looks like the main update is operation_mode update or create 👍
Description
Fixes #3377
If the new process is similar to the workflow process, update it instead of creating new ones. this helps maintain the number of workflow memories.