Skip to content

Conversation

@hesamsheikh
Copy link
Collaborator

Description

Fixes #3377
If the new process is similar to the workflow process, update it instead of creating new ones. this helps maintain the number of workflow memories.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch workflow-dynamic-save

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Nov 26, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 43 milestone Nov 26, 2025
@fengju0213 fengju0213 self-requested a review November 28, 2025 10:46
Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @hesamsheikh sorry for late reply!!

Comment on lines +127 to +135
target_workflow_filename: Optional[str] = Field(
description=(
"When operation_mode is 'update', specify the exact filename "
"(without .md extension) of the loaded workflow to update. "
"Must match one of the loaded workflow filenames exactly. "
"Leave empty or null when operation_mode is 'create'."
),
default=None,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your opinion, do you think if given the file name we can always assume its update ? @hesamsheikh

Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like the main update is operation_mode update or create 👍

@hesamsheikh hesamsheikh merged commit e22d29b into master Dec 11, 2025
14 checks passed
@hesamsheikh hesamsheikh deleted the workflow-dynamic-save branch December 11, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhance] Workflow Memory Dynamic Save

6 participants