Skip to content

fix onValueChanges is called on programmatic value changes on Android #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix onValueChanges is called on programmatic value changes on Android #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a10182
fix onValueChanges is called on programmatic value changes on Android
Aug 1, 2022
b3970f4
fix onValueChanges is called on programmatic value changes on Android
Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public void onStopTrackingTouch(SeekBar seekbar) {
new ReactSliderEvent(
seekbar.getId(),
((ReactSlider)seekbar).toRealProgress(seekbar.getProgress()),
!((ReactSlider)seekbar).isSliding()));
false));
}
};

Expand Down
9 changes: 8 additions & 1 deletion package/src/Slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,14 @@ const SliderComponent = (

const onValueChangeEvent = onValueChange
? (event: Event) => {
onValueChange(event.nativeEvent.value);
let userEvent = true;
if (Platform.OS === 'android') {
// On Android there's a special flag telling us the user is
// dragging the slider.
userEvent =
event.nativeEvent.fromUser != null && event.nativeEvent.fromUser;
}
userEvent && onValueChange(event.nativeEvent.value);
}
: null;

Expand Down