Fix: onAccessibilityAction causes crash #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
added
bug report
BartoszKlonowski
force-pushed
the
fix/accessibility-action-ios-crash
branch
from
f401d9a to
af2c710
Compare
|
CC: @alexkramerbanjo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #250
It adds the explicit implementation of utilizing the
onAccessibilityActionproperty passed to the Slider exposed to JS side.The implementation does not overrides the implementation of the event itself, but it takes that property directly from props passed to Slider as part of
ViewProps.The extracted property is explicity passed to Slider component implementation.
Tested on simulator using the Accessibility Inspector from Xcode tools.