Fix: OnSlidingComplete is launched at the end of tap event
#336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Start event of Slider for Android sends the lastValue which acts as a point where the thumb was when slider was clicked. This value should also be sent on iOS platform to keep the behavior consisent.
The state machine for handling the Start->Update->Complete events is used to avoid multiplication of events when flags for sending status are used. This solution was implemented because there's no clear way to override the default drag/tap events on the slider. So to avoid reimplementing the whole architecture the flags and state machines has been used.
BartoszKlonowski
added
platform: iOS
The `EventType` enum has been previously used to recognize the action performed on the Slider. But due to using flags for a state machine this enum is no longer required and can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #306
It delivers the
onSlidingCompleteevent fired at the end of tap gesture.The implementation is done for both Windows and iOS platforms:
This solution is different from other platforms, as currently there's no decent way to override the drag/tap gestures handlers, which would allow to easily launch selected events.
NOTE: the additional change implemented for iOS is that it is now consistent with the Android platform - the start event has the starting value, while change and complete events are sending the updated value of Slider.