Fix: Remove redundant React, Rreact Native & React Native Windows from devDependencies
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
added
the
dependencies
deorst
approved these changes
Aug 29, 2021
|
TANK U =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #307
It removes the React, React Native and React Native Windows from
devDependencieswhen it comes to src/package.json - package dependencies.The reason that these can be safely removed is that these libraries are also listed in the
peerDependencieswhich makes them still being checked when installing.Both workspaces should not be affected as src/ should use the packages provided by the consumer, while example/ should satisfy
peerDependenciesby having them installed in the example app(moreover: example is about to change in upcoming deliveries).