Regenerate client_mock in service/worker/parentclosepolicy using mockgen #7226
Conversation
ansidev
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Head branch was pushed to by a user without write access
ansidev
force-pushed
the
cadence-6759-service-worker-parentclosepolicy
branch
from
ef7d6bc to
105424b
Compare
| @@ -319,7 +318,7 @@ func (s *transferActiveTaskExecutorSuite) TestProcessActivityTask_Ratelimits() { | |||
| s.NoError(err) | |||
| s.mockExecutionMgr.On("GetWorkflowExecution", mock.Anything, mock.Anything).Return(&persistence.GetWorkflowExecutionResponse{State: persistenceMutableState}, nil) | |||
|
|
|||
| // expected calls to matching if task processing is allowed | |||
There was a problem hiding this comment.
The calls are to matching (the service) - so the comment was correct
There was a problem hiding this comment.
@jakobht I updated two comments a little bit. Please take a look!
| @@ -491,7 +490,7 @@ func (s *transferActiveTaskExecutorSuite) TestProcessDecisionTask_Ratelimits() { | |||
| s.NoError(err) | |||
| s.mockExecutionMgr.On("GetWorkflowExecution", mock.Anything, mock.Anything).Return(&persistence.GetWorkflowExecutionResponse{State: persistenceMutableState}, nil) | |||
|
|
|||
| // expected calls to matching if task processing is allowed | |||
There was a problem hiding this comment.
The calls are to matching (the service) - so the comment was correct
| errs := []error{nil, &types.CancellationAlreadyRequestedError{}, &types.EntityNotExistsError{}} | ||
| return errs[rand.Intn(len(errs))] |
There was a problem hiding this comment.
I think this is a bad change - lets not do that.
There was a problem hiding this comment.
@jakobht This change only rename the local variable errors because it collides with the imported package errors.
| errs := []error{nil, &types.EntityNotExistsError{}} | ||
| return errs[rand.Intn(len(errs))] |
There was a problem hiding this comment.
I think this is a bad change - lets not do that.
There was a problem hiding this comment.
@jakobht This change only rename the local variable errors because it collides with the imported package errors.
ansidev
force-pushed
the
cadence-6759-service-worker-parentclosepolicy
branch
2 times, most recently
from
e8c91b8 to
740c88d
Compare
ansidev
force-pushed
the
cadence-6759-service-worker-parentclosepolicy
branch
from
740c88d to
8c86a5d
Compare
What changed?
Why?
How did you test it?
local tests
Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A