Compiler: move c2_assert to c2 #306
Open
+165
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chqrlie
force-pushed
the
assert
branch
2 times, most recently
from
ac7bab2 to
f6f55a9
Compare
|
It also has auto-arg changes.. please keep commits small so it's easier for me to review.. |
|
I just split this PR into 2 separate commits:
|
bvdberg
reviewed
Jun 30, 2025
|
|
||
| if (a.getCall()) { | ||
| qt = ma.analyseExpr(a.getCall2(), true, RHS); | ||
| if (qt.isInvalid()) return; |
There was a problem hiding this comment.
In which case will a.getCall() be nil?
There was a problem hiding this comment.
the call expression is only constructed by the parser if asserts are enabled. The expression is always parsed and stored for the analyser.
chqrlie
force-pushed
the
assert
branch
3 times, most recently
from
863c3f0 to
b91e9ff
Compare
* add `auto_func` function parameter attribute * reject invalid combinations of `auto_xxx` attributes * fix tests
* compute the assert string and function call at parse time * add c2_assert module in C library interface libs/libc/c2_assert.c2i * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto_funcfunction parameter attributeauto_xxxattributes