Skip to content

Conversation

Daniel-Liu-c0deb0t
Copy link
Contributor

This was causing an issue in the stdarch WASM CI (rust-lang/stdarch#1004 (comment)). I'm assuming that V128AnyTrue was mistakenly not added in the type_of function, because all the other operators are there. If this was intentional, please let me know.

Copy link
Member

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good fix; it looks like #2594 left out this line when switching from [I8x16|I16x8|I32x4]AnyTrue to V128AnyTrue.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:wasm labels Feb 16, 2021
@pchickey pchickey merged commit 38b63f5 into bytecodealliance:main Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:wasm cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants