Generalize "global values" to "templates". #1267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename "global values" to "templates", to better describe their role as expressions which can be provided by frontends and expanded by the code generator as needed. And, start to generalize them, by introducing `Call` and `IfElse` templates. This is a step towards generalizing templates into a form that can be independent of Cranelift, and allow embedding environments to provide a single description of their data structures which is independent of any specific JIT. And, it's a step toward being able to use templates to describe GC barrier instruction sequences. This also helps avoid some confusion between Cranelift IR global values, wasm global variables, global variable data objects, and "global" variables in regalloc.
github-actions
bot
added
cranelift:docs
cranelift
Subscribe to Label ActionThis issue or pull request has been labeled: "cranelift", "cranelift:docs", "cranelift:meta", "cranelift:module" Users Subscribed to "cranelift"To subscribe or unsubscribe from this label, edit the |
|
Note I had questions left unanswered in bytecodealliance/cranelift#1299 (review) and bytecodealliance/cranelift#1299 (comment), and it would be nice to address them before review. |
|
I still think something along the lines of this PR are an interesting idea to pursue, but the actual code here is fairly out of date for now, so I'll close this PR now. |
|
The code is now here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "global values" to "templates", to better describe their role as
expressions which can be provided by frontends and expanded by the code
generator as needed. And, start to generalize them, by introducing
CallandIfElsetemplates.This is a step towards generalizing templates into a form that can be
independent of Cranelift, and allow embedding environments to provide a
single description of their data structures which is independent of any
specific JIT. And, it's a step toward being able to use templates to
describe GC barrier instruction sequences.
This also helps avoid some confusion between Cranelift IR global values,
wasm global variables, global variable data objects, and "global"
variables in regalloc.
This is a continuation of bytecodealliance/cranelift#1299, rebased on trunk.