Allow bare try blocks for exceptions
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoops, this was not quite right as |
The exception handling spec now allows bare `try` blocks that have no corresponding `catch` (or other) clauses following it. These blocks are semantically equivalent to `block`. Related spec PR: WebAssembly/exception-handling#157
|
Thanks for this! If you'd like a new publish with these changes and updates just let me know as well. |
|
@alexcrichton Oh yes, thanks that would be helpful! :) This is the last PR I have for this current batch of changes, so a version bump and publish would be helpful to be able to use this from SpiderMonkey tests. |
|
Ok, published now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for bare
tryblocks (try blocks that have nocatch,delegate, etc). These are equivalent to a plainblockand were added to the spec recently (in order to simplify the grammar and avoid special cases): WebAssembly/exception-handling#157There's a PR pending review for wabt as well: WebAssembly/wabt#1676
I tested the wasm-tools patch against the pending wabt PR and I believe they should agree. It should be ok to merge this before wabt as the only conflicting test is a failure test (
bad-try-no-catch.txt) that is not run byroundtrip.rs.