Gate component model functions with multiple returns #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is an implementation of WebAssembly/component-model#368 in this repository. The intention here is along the lines of a few other recent restrictions which is to avoid outright removing support and instead stage the changes a bit. To that end a new feature flag is added and multi-return functions are now gated behind this feature flag. Tests are updated to avoid using it and otherwise the actual removal of supporting code is deferred to a later date.
pchickey
approved these changes
Jul 15, 2024
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Jul 24, 2024
This fixes a fuzz issue from bytecodealliance#1670 which wasn't fixed at the time and has been found on oss-fuzz.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
This fixes a fuzz issue from #1670 which wasn't fixed at the time and has been found on oss-fuzz.
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jun 27, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jun 27, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 1, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 3, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 9, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 10, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 11, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
added a commit
to hyperlight-dev/hyperlight
that referenced
this pull request
Jul 14, 2025
This was a bit more involved due to a big change in the way function return types are handled. The orginal change was done in WebAssembly/component-model#368 and put initially put behind a feature flag in bytecodealliance/wasm-tools#1670. In 0.226.0 version of wasmparser this feature flag was removed simplify the return results. This in turn simplifies the handling of the results here as well. Signed-off-by: James Sturtevant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an implementation of WebAssembly/component-model#368 in this repository. The intention here is along the lines of a few other recent restrictions which is to avoid outright removing support and instead stage the changes a bit. To that end a new feature flag is added and multi-return functions are now gated behind this feature flag. Tests are updated to avoid using it and otherwise the actual removal of supporting code is deferred to a later date.