Expand the windows-sys dependency to include 0.60.0. #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the windows-sys dependency to ">=0.52, <0.61", to support the new windows-sys 0.60. windows-sys 0.60 does make one change that affected rustix, which is to move the `BOOL` type from `windows_sys::Win32::Foundation::BOOL` to `windows_sys::core::BOOL`, so to support both old and new versions, just hard-code the `BOOL` type, as it's just an `i32` and always will be.
sunfishcode
force-pushed
the
sunfishcode/update-windows-sys
branch
from
ea9c396 to
4ba03f7
Compare
sunfishcode
added a commit
that referenced
this pull request
Jul 15, 2025
* Expand the windows-sys dependency to include 0.60.0. Expand the windows-sys dependency to ">=0.52, <0.61", to support the new windows-sys 0.60. windows-sys 0.60 does make one change that affected rustix, which is to move the `BOOL` type from `windows_sys::Win32::Foundation::BOOL` to `windows_sys::core::BOOL`, so to support both old and new versions, just hard-code the `BOOL` type, as it's just an `i32` and always will be. * Pin more packages for the MSRV build. * Fix warnings. * Disable more test on FreeBSD.
sunfishcode
added a commit
that referenced
this pull request
Jul 15, 2025
* Expand the windows-sys dependency to include 0.60.0. Expand the windows-sys dependency to ">=0.52, <0.61", to support the new windows-sys 0.60. windows-sys 0.60 does make one change that affected rustix, which is to move the `BOOL` type from `windows_sys::Win32::Foundation::BOOL` to `windows_sys::core::BOOL`, so to support both old and new versions, just hard-code the `BOOL` type, as it's just an `i32` and always will be. * Pin more packages for the MSRV build. * Fix warnings. * Disable more test on FreeBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the windows-sys dependency to ">=0.52, <0.61", to support the new windows-sys 0.60.
windows-sys 0.60 does make one change that affected rustix, which is to move the
BOOLtype fromwindows_sys::Win32::Foundation::BOOLtowindows_sys::core::BOOL, so to support both old and new versions, just hard-code theBOOLtype, as it's just ani32and always will be.