Skip to content

Conversation

SozinovD
Copy link
Contributor

@SozinovD SozinovD commented Sep 8, 2025

implement ability to add arbitrary manifests to release

@SozinovD SozinovD marked this pull request as ready for review September 8, 2025 18:32
@burningalchemist
Copy link
Owner

Hey @SozinovD, thanks for your contribution!

Do you have any particular ideas or use cases on how extraManifests might be used in the sql_exporter helm chart? I believe users might find it useful.

Also, please make sure to check Dev Notes (https://github.com/burningalchemist/sql_exporter/tree/master/helm#dev-notes).

The version in Chart.yaml also needs a bump up, I'd say for the minor value as this a new field.

@SozinovD
Copy link
Contributor Author

SozinovD commented Sep 9, 2025

For example i use it with External Secret Operator for automated credentials rotation
I saw extraManifests in kube-prometheus-stack chart, so i consider this a rather good practice

I'll generate docs a bit later, thanks for pointing out

UPD: done with version and docs

@burningalchemist
Copy link
Owner

burningalchemist commented Sep 9, 2025

@SozinovD, thanks! Yeah, seems a good practice to me too.
Could you please update the version to 0.13.0 instead? I think 0.12.6 might have issues for those trying to upgrade the chart (but we'll see in the pipeline run).

UPD: I'm looking into the pipeline action failure. 👍

@SozinovD
Copy link
Contributor Author

SozinovD commented Sep 9, 2025

Yep, changed version to 0.13.0

@burningalchemist burningalchemist changed the title Create extramanifests.yaml helm: add extraManifests field Sep 9, 2025
@burningalchemist burningalchemist changed the title helm: add extraManifests field feat(helm): add extraManifests field Sep 9, 2025
@burningalchemist burningalchemist merged commit f49b7a7 into burningalchemist:master Sep 9, 2025
4 checks passed
@burningalchemist
Copy link
Owner

@SozinovD it's merged, and should be released soon. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants