-
-
Notifications
You must be signed in to change notification settings - Fork 88
feat(helm): add extraManifests field #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @SozinovD, thanks for your contribution! Do you have any particular ideas or use cases on how extraManifests might be used in the sql_exporter helm chart? I believe users might find it useful. Also, please make sure to check Dev Notes (https://github.com/burningalchemist/sql_exporter/tree/master/helm#dev-notes). The version in Chart.yaml also needs a bump up, I'd say for the minor value as this a new field. |
For example i use it with External Secret Operator for automated credentials rotation I'll generate docs a bit later, thanks for pointing out UPD: done with version and docs |
@SozinovD, thanks! Yeah, seems a good practice to me too. UPD: I'm looking into the pipeline action failure. 👍 |
Yep, changed version to |
implement ability to add generic manifests to release
5ea115c
to
5f65e5c
Compare
@SozinovD it's merged, and should be released soon. Thanks! 👍 |
implement ability to add arbitrary manifests to release